Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package management additions #591

Closed
wants to merge 3 commits into from
Closed

Package management additions #591

wants to merge 3 commits into from

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Nov 9, 2017 •
edited
Loading

This PR refactors some of the in-progress dbt deps work and handles errors a little nicer.

Packages are extracted to the correct directory:

$ tree dbt_modules/ -L 1
dbt_modules/
├── dbt-utils
├── downloads
└── redshift

Invalid version specified for a dep:

$ dbt deps
Encountered an error:
Could not find a matching version for package fishtown-analytics/dbt-utils
  Requested range: =2.0.0, =2.0.0
  Available versions: ['1.0.0', '0.9.0']

Conflicting versions are specified:

$ dbt deps
Encountered an error:
Could not find a satisfactory version of fishtown-analytics/dbt-utils:
Specified versions: [>1.0.0, <1.0.0]

Nonexistent package is specified:

$ dbt deps
Encountered an error:
Package fishtown-analytics/snowflake was not found in the package index

TODO:

  • Extract to correct dir
  • Refactor deps task
  • Nice error messages
  • Work with local packages
  • Work with remote repo (github, bitbucket, etc)
  • Recursively clone deps for non-hub packages?
  • Specify a required dbt version range in packages

@drewbanin drewbanin added this to the Package Management milestone Nov 9, 2017
@drewbanin drewbanin modified the milestones: Package Management, 0.9.2 Jan 2, 2018
@drewbanin
Copy link
Contributor Author

TODO: Merge back into #542

@drewbanin drewbanin modified the milestones: 0.9.2, Package Management Jan 12, 2018
@drewbanin drewbanin closed this Jan 29, 2018
@drewbanin drewbanin deleted the package-management-additions branch September 19, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcarthur cmcarthur Awaiting requested review from cmcarthur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Package Management
Development

Successfully merging this pull request may close these issues.
1 participant
@drewbanin